Reviewing code without nitpicking

Back to list2023-11-10
You

How do I review without turning it into style comments?

ChatGPT

Automate style entirely, then the review can only be about substance. What remains worth saying: this breaks under concurrency, this loses an error, this name means something else in our codebase. If a comment could be a lint rule, make it one.

You

The diff is in an area I do not know. What do I do?

ChatGPT

Say so and review what you can: tests, error handling, whether the description matches the change. An approval that means "I did not understand this" is worse than no review, and a question in the thread is often more useful than the approval would have been.

You

Big PRs sit for days. How do we fix that?

ChatGPT

Make them smaller, because attention does not scale with size: a 50 line change gets real review, a 2000 line change gets a rubber stamp. Splitting by mechanical versus meaningful is the easiest cut, since the mechanical half needs eyes but not thought.